kristina closed this revision.
kristina added a comment.
In https://reviews.llvm.org/D50246#1229191, @lebedev.ri wrote:
> In https://reviews.llvm.org/D50246#1229177, @kristina wrote:
>
> > In https://reviews.llvm.org/D50246#1229152, @rogfer01 wrote:
> >
> > > Hi @kristina .
> > >
> > > Sure, I
lebedev.ri added a comment.
In https://reviews.llvm.org/D50246#1229177, @kristina wrote:
> In https://reviews.llvm.org/D50246#1229152, @rogfer01 wrote:
>
> > Hi @kristina .
> >
> > Sure, I didn't mean to do that broader change here. Apologies if it read
> > that way.
> >
> > Would it be
kristina added a comment.
In https://reviews.llvm.org/D50246#1229152, @rogfer01 wrote:
> Hi @kristina .
>
> Sure, I didn't mean to do that broader change here. Apologies if it read that
> way.
>
> Would it be acceptable to add an empty `--sysroot=` to the test? I can post
> the change for
rogfer01 added a comment.
Hi @kristina .
Sure, I didn't mean to do that broader change here. Apologies if it read that
way.
Would it be acceptable to add an empty `--sysroot=` to the test? I can post the
change for review in another diff.
Thanks a lot.
Repository:
rC Clang
kristina added a comment.
In https://reviews.llvm.org/D50246#1229068, @rogfer01 wrote:
> Thanks for reopening this @kristina.
>
> I suggest passing `--sysroot=` to make sure we see the expected behaviour
> when the sysroot is actually empty.
>
> Note that this would not really test the scenario
rogfer01 added a comment.
Thanks for reopening this @kristina.
I suggest passing `--sysroot=` to make sure we see the expected behaviour when
the sysroot is actually empty.
Note that this would not really test the scenario where `DEFAULT_SYSROOT` is
empty **and** no `--sysroot` appears in the
kristina reopened this revision.
kristina added a comment.
This revision is now accepted and ready to land.
Seems to be causing a test failure for someone (per comment in
https://reviews.llvm.org/rL341655), reopened it for now.
Repository:
rC Clang
https://reviews.llvm.org/D50246
kristina closed this revision.
kristina added a comment.
Closed by https://reviews.llvm.org/rC341655.
Repository:
rC Clang
https://reviews.llvm.org/D50246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kristina added a comment.
Going to land it as it's approved by code owner.
Repository:
rC Clang
https://reviews.llvm.org/D50246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lewis-revill added a comment.
@asb can we get this committed?
Repository:
rC Clang
https://reviews.llvm.org/D50246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lewis-revill updated this revision to Diff 163339.
lewis-revill added a comment.
Rebased and ensured that -fuse-init-array is always used (as intended in
https://reviews.llvm.org/D50043), since addClangTargetOptions is overidden for
this patch.
Repository:
rC Clang
asb accepted this revision.
asb added a comment.
Looks good to me, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D50246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lewis-revill updated this revision to Diff 162179.
lewis-revill added a comment.
Added tests for the case where `--sysroot` is not provided.
Repository:
rC Clang
https://reviews.llvm.org/D50246
Files:
lib/Driver/ToolChains/RISCV.cpp
lib/Driver/ToolChains/RISCV.h
asb added a comment.
Herald added a subscriber: jocewei.
Thanks for the patch and sorry for the delay. Once someone else marked it
accepted it moves to a separate list in Phabricator - obviously I need to check
the 'waiting on authors' list better.
As I see it are two changes here:
1.
simoncook accepted this revision.
simoncook added a comment.
This revision is now accepted and ready to land.
My tests now look better, there are a couple of failures, but this seems to be
a bug in newlib, rather than with clang/this patch (the bug was masked before
as we would have been
lewis-revill updated this revision to Diff 160602.
lewis-revill added a comment.
Fixed this issue by adding -nostdsysteminc to the Clang target options,
preventing the frontend from generating additional include paths.
Repository:
rC Clang
https://reviews.llvm.org/D50246
Files:
simoncook requested changes to this revision.
simoncook added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: PkmX.
I've tested this, regression tests involving linking now mostly pass as crt0
can now be found, but it seems that system headers are still being
lewis-revill added a comment.
@xbolva00 In my opinion this is an issue for another revision. Personally I
would choose to rename/move the other RISCV driver file to something along the
lines of RISCVLinux, however I think it is best for @asb to decide since he is
the code owner for the RISC-V
xbolva00 added a comment.
Nico Webber (cfe-commits)
"I'm getting this warning from the mac linker after this commit:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
warning same member name (libclangDriver.RISCV.o) in output file used for
input
lewis-revill updated this revision to Diff 158994.
lewis-revill added a comment.
Modified test which assumed the path to C++ includes was determined without use
of the sysroot path.
Repository:
rC Clang
https://reviews.llvm.org/D50246
Files:
lib/Driver/ToolChains/RISCV.cpp
lewis-revill created this revision.
lewis-revill added reviewers: asb, simoncook, edward-jones.
Herald added subscribers: cfe-commits, rkruppe, the_o, brucehoult,
MartinMosbeck, rogfer01, mgrang, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,
sabuasal, apazos, johnrusso, rbar.
Extends r338385
21 matches
Mail list logo
