vsapsai added a comment.
Thanks for the review.
Repository:
rL LLVM
https://reviews.llvm.org/D50543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339451: [libcxx] Mark charconv tests as failing for previous
libcxx versions. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Ship it!
https://reviews.llvm.org/D50543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lichray added a comment.
LGTM. @ldionne 's job to confirm.
https://reviews.llvm.org/D50543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai created this revision.
vsapsai added reviewers: mclow.lists, ldionne.
Herald added a reviewer: EricWF.
Herald added subscribers: dexonsmith, christof.
was added in r338479. Previous libcxx versions don't have
this functionality and corresponding tests should be failing.
