[PATCH] D50724: SafeStack: Disable Darwin support

2018-08-14 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL339720: SafeStack: Disable Darwin support (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50724 Files:

[PATCH] D50724: SafeStack: Disable Darwin support

2018-08-14 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50724: SafeStack: Disable Darwin support

2018-08-14 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich added a comment. In https://reviews.llvm.org/D50724#1199345, @kubamracek wrote: > Doesn't this need any tests to be updated? Otherwise, LGTM. There were no Darwin-specific safestack driver tests. I ran check-clang just to make sure and it passes. Repository: rC Clang

[PATCH] D50724: SafeStack: Disable Darwin support

2018-08-14 Thread Kuba (Brecka) Mracek via Phabricator via cfe-commits
kubamracek added a comment. Doesn't this need any tests to be updated? Otherwise, LGTM. Repository: rC Clang https://reviews.llvm.org/D50724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50724: SafeStack: Disable Darwin support

2018-08-14 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich created this revision. vlad.tsyrklevich added reviewers: pcc, kubamracek. Herald added a subscriber: cfe-commits. Darwin support does not appear to be used as evidenced by the fact that the runtime has never supported non-trivial programs. Repository: rC Clang