[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. Please see https://reviews.llvm.org/D55136 for the patch addressing these issues. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/ https://reviews.llvm.org/D52879 ___ cfe-commits

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. In D52879#1314855 , @mantognini wrote: > Thank you for the detailed review. I'll work on a patch and add you as > reviewer once done (prob. on Monday though). That's fine. Thanks for your contribution ! Repository: rC

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. Thank you for the detailed review. I'll work on a patch and add you as reviewer once done (prob. on Monday though). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/ https://reviews.llvm.org/D52879

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. In D52879#1314694 , @mantognini wrote: > In D52879#1311177 , @riccibruno > wrote: > > > And moreover I believe this change is subtly incorrect for the following > > reason: > > The

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. In D52879#1311177 , @riccibruno wrote: > And moreover I believe this change is subtly incorrect for the following > reason: > The type that is passed into the constructor of the call expression is the > type > of the call

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. In D52879#1311177 , @riccibruno wrote: > And moreover I believe this change is subtly incorrect for the following > reason: > The type that is passed into the constructor of the call expression is the > type > of the call

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. And moreover I believe this change is subtly incorrect for the following reason: The type that is passed into the constructor of the call expression is the type of the call expression, and not the return type. The difference between the return type and the type of the

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. In D52879#1309856 , @mantognini wrote: > In D52879#1309734 , @riccibruno > wrote: > > > I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` > >

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. In D52879#1309734 , @riccibruno wrote: > I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` > (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, >

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, `Builtin::BI__builtin_dump_struct` and so on...). Is there a reason for not removing them ? Repository: rC Clang

[PATCH] D52879: Derive builtin return type from its definition

This revision was automatically updated to reflect the committed changes. Closed by commit rC347658: Derive builtin return type from its definition (authored by mantognini, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/

[PATCH] D52879: Derive builtin return type from its definition

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! It looks reasonable small change! Repository: rC Clang https://reviews.llvm.org/D52879 ___ cfe-commits mailing list

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. ping Repository: rC Clang https://reviews.llvm.org/D52879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52879: Derive builtin return type from its definition

Anastasia added a comment. LGTM from OpenCL side! Repository: rC Clang https://reviews.llvm.org/D52879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52879: Derive builtin return type from its definition

mantognini created this revision. mantognini added reviewers: Anastasia, spatel. Herald added subscribers: cfe-commits, kristina. mantognini added dependencies: D52873: Remove unwanted signedness conversion from tests, D52875: Fix definitions of __builtin_(add|sub|mul)_overflow. Prior to this