This revision was automatically updated to reflect the committed changes.
Closed by commit rL344777: [clangd] Remove the overflow log. (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53400
Files:
hokein updated this revision to Diff 170159.
hokein added a comment.
Minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53400
Files:
clangd/XRefs.cpp
clangd/index/Index.cpp
clangd/index/Index.h
unittests/clangd/IndexTests.cpp
Index:
hokein added inline comments.
Comment at: clangd/XRefs.cpp:43
+ if (Line >= SymbolLocation::Position::MaxLine)
+log("Get an overflowed line");
+ return Line;
sammccall wrote:
> Log message could use more context. And I think it'd be really useful to
>
hokein updated this revision to Diff 170157.
hokein marked an inline comment as done.
hokein added a comment.
Log the whole location when overflow happens.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53400
Files:
clangd/XRefs.cpp
clangd/index/Index.cpp
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Some nitty ideas about the log message, but whatever you think is best.
Comment at: clangd/XRefs.cpp:43
+ if (Line >= SymbolLocation::Position::MaxLine)
+log("Get
hokein updated this revision to Diff 170091.
hokein added a comment.
Add log in XRefs.cpp.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53400
Files:
clangd/XRefs.cpp
clangd/index/Index.cpp
Index: clangd/index/Index.cpp
sammccall added a comment.
After looking at the examples, I'm reassured that we don't really care about
tracking precise locations of those references :-)
I'd suggest adding the logging just to where the field is *read* in XRefs.cpp
(check if it's max-value).
That would cover a bunch of the
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
LLVM codebase has generated files (all are build/Target/XXX/*.inc) that
exceed the MaxLine & MaxColumn. Printing these log would be noisy.
