[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

This revision was automatically updated to reflect the committed changes. Closed by commit rC344915: Ensure sanitizer check function calls have a !dbg location (authored by adrian, committed by ). Repository: rC Clang https://reviews.llvm.org/D53459 Files: lib/CodeGen/CGExpr.cpp

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D53459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl updated this revision to Diff 170434. aprantl added a comment. further simplify testcase https://reviews.llvm.org/D53459 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/ubsan-check-debuglocs.cpp Index: test/CodeGenCXX/ubsan-check-debuglocs.cpp

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl updated this revision to Diff 170433. aprantl added a comment. Simplify testcase https://reviews.llvm.org/D53459 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/ubsan-check-debuglocs.cpp Index: test/CodeGenCXX/ubsan-check-debuglocs.cpp

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

vsk added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); aprantl wrote: > vsk

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); vsk wrote: > Why

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

vsk added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); Why shouldn't this always

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl created this revision. aprantl added a reviewer: vsk. Function calls without a !dbg location inside a function that has a DISubprogram make it impossible to construct inline information and are rejected by the verifier. This patch ensures that sanitizer check function calls have a !dbg