[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rC348031: [analyzer] Evaluate all non-checker config options before analysis (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D53692?vs=172856=176183#toc

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus added a comment. In D53692#1313956 , @NoQ wrote: > In D53692#1293781 , @NoQ wrote: > > > In D53692#1293778 , @Szelethus > > wrote: > > > > > Did you know that

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

NoQ added a comment. Herald added subscribers: gamesh411, baloghadamsoftware. In D53692#1293781 , @NoQ wrote: > In D53692#1293778 , @Szelethus wrote: > > > Did you know that clang unit tests do not run with

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

NoQ added a comment. In https://reviews.llvm.org/D53692#1293778, @Szelethus wrote: > Did you know that clang unit tests do not run with check-clang-analysis? Well, *some* unit tests definitely do run under check-clang-analysis. Repository: rC Clang https://reviews.llvm.org/D53692

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus marked an inline comment as done. Szelethus added a comment. Thanks! This patch was the last for a while directly related to non-checker config options, I'm currently stuck on them as I unearthed countless bugs that I have to fix beforehand. (Did you know that clang unit tests do not

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, this is really wonderful. Comment at: test/Analysis/analyzer-config.cpp:1 // RUN: %clang_analyze_cc1 -triple x86_64-apple-darwin10 %s -o /dev/null

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus updated this revision to Diff 172856. Szelethus set the repository for this revision to rC Clang. Szelethus added a comment. - Moved initializer functions to `CompilerInvocation.cpp`, like every other Options-like class. - The fields for options are no longer `Optional` - Fixed the

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: test/Analysis/analyzer-config.c:4-12 void bar() {} void foo() { // Call bar 33 times so max-times-inline-large is met and // min-blocks-for-inline-large is checked for (int i = 0;

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

NoQ added inline comments. Comment at: test/Analysis/analyzer-config.c:4-12 void bar() {} void foo() { // Call bar 33 times so max-times-inline-large is met and // min-blocks-for-inline-large is checked for (int i = 0; i < 34; ++i) { bar(); }

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:227 -CTUDir = getStringOption("ctu-dir", ""); -if (!llvm::sys::fs::is_directory(*CTUDir)) - CTUDir = ""; Szelethus wrote: > This check should and will be moved

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus added a comment. Also, thank you so much for the feedback on this, and almost every single other patch I made! https://reviews.llvm.org/D53692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus added a comment. In https://reviews.llvm.org/D53692#1285091, @NoQ wrote: > I guess i'm running out of steam for today :) > > > `Opts.shouldDoThat()` -> `Opts.ShouldDoThat.getValue()` > > Is this really unavoidable? Like, what makes them optional when they're > always non-optional?

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

NoQ added a comment. I guess i'm running out of steam for today :) > `Opts.shouldDoThat()` -> `Opts.ShouldDoThat.getValue()` Is this really unavoidable? Like, what makes them optional when they're always non-optional? Maybe just somehow prevent un-eagerly-initialized AnalyzerConfig from

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus added a comment. Polite ping. :) https://reviews.llvm.org/D53692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus added a comment. What are the feelings on moving some functions to the header file? That's the one thing I'm unsure about regarding this patch. I could've moved them to `CompilerInvocation.cpp`, but I since I plan on making `ConfigTable` private, `CompilerInvocation` needs to be a

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus updated this revision to Diff 171094. Szelethus edited the summary of this revision. https://reviews.llvm.org/D53692 Files: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def include/clang/StaticAnalyzer/Core/AnalyzerOptions.h lib/Frontend/CompilerInvocation.cpp

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus added a comment. The reason why I removed the getter functions and went ahead with the gigantic refactor is that getter functions actually changed the state of `AnalyzerOptions`, as they were responsible with the initialization of each option. Now, in the .def file, not all options

[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Szelethus created this revision. Szelethus added reviewers: xazax.hun, NoQ, george.karpenkov, MTC, rnkovacs. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, szepet, whisperity. Szelethus added a dependency: D53483: [analyzer] Restrict