[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348188: Re-apply r347954 [analyzer] Nullability: Dont detect post factum violation... (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ added a comment. Wasn't me: rC347970 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54017/new/ https://reviews.llvm.org/D54017 ___ cfe-commits mailing list

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ reopened this revision. NoQ added a comment. This revision is now accepted and ready to land. Reverted as rC347956 due to http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/26658 - will have a look tomorrow. Repository: rC Clang

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rC347954: [analyzer] Nullability: Dont detect post factum violation on concrete values. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

Szelethus added a comment. I have no other objections, looks great! Comment at: test/Analysis/nullability.mm:3-4 // RUN: %clang_analyze_cc1 -fblocks

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ added inline comments. Comment at: test/Analysis/nullability.mm:3-4 // RUN: %clang_analyze_cc1 -fblocks

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ updated this revision to Diff 172645. NoQ marked 3 inline comments as done. NoQ added a comment. Fix comments, update comments. Before i forget - also add invariant violation markers to the exploded graph, which helped me a lot with debugging this bug. https://reviews.llvm.org/D54017

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

Szelethus added a comment. Thanks for summarizing the problem so well in the summary! I should start doing that too. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:343-346 + // There should have originally been a symbol. If it was a concrete value + // to

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ added a comment. It also seems that we still have a false negative under ARC, but i didn't bother investigating it. Just in case, i added `-fobjc-arc` run-lines to older tests to see if there's any difference, and it turned out that there's no difference. Repository: rC Clang

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, george.karpenkov. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. This false negative bug was exposed by https://reviews.llvm.org/D18860.