[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

This revision was automatically updated to reflect the committed changes. Closed by commit rL351097: [analyzer] [PR39792] false positive on strcpy targeting struct members (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

george.karpenkov added a comment. @Pierre-vh The patch does not compile due to unmatched braces. Please do test and compile before submitting! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 ___

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

george.karpenkov added a comment. Whoops, sorry. There were holidays, and then I did forget about this patch. I'll commit this now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 ___ cfe-commits

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh added a comment. Hello! I'm trying one last ping since it's been a month and it hasn't been commited (I think). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 ___ cfe-commits mailing

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh added a comment. Hello! I'm pinging since it's been a week. If someone can commit this patch on my behalf, that would be great. Thank you :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Szelethus added a comment. I like what I'm seeing. In D55226#1320281 , @Pierre-vh wrote: > Hi again! > > As I'm quite new to this, I don't know what the next step is. Do we need to > wait for more people to review this diff? > What happens when it's

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh marked an inline comment as done. Pierre-vh added a comment. Hi again! As I'm quite new to this, I don't know what the next step is. Do we need to wait for more people to review this diff? What happens when it's considered "ready"? How is it committed? (I don't have commit access)

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh updated this revision to Diff 176676. Pierre-vh added a comment. Here's the diff without the extra newline :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 Files: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Szelethus added a comment. Thanks for the fix! :) In D55226#1318853 , @Pierre-vh wrote: > Hello again! I updated the diff and completely removed the outer if. Please > let me know what you think! If we're sure that `Target` isn't a `nullptr`, it's

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh updated this revision to Diff 176661. Pierre-vh added a comment. Hello again! I updated the diff and completely removed the outer if. Please let me know what you think! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 Files:

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

MTC added a comment. Please add more context using the `-U` option, like `git diff -U9 ...`. In D55226#1317119 , @Pierre-vh wrote: > Sadly I'm not experienced enough to think of every case that should pass this > check, so I limited myself to just

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh added a comment. In D55226#1317083 , @george.karpenkov wrote: > Thank you for the fix, but how far can the pattern matching go? Seems easy > enough to think of cases not covered by the above. > In any case, the fix looks good. Hey, Sadly

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thank you for the fix, but how far can the pattern matching go? Seems easy enough to think of cases not covered by the above. In any case, the fix looks good. Repository:

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh created this revision. Pierre-vh added reviewers: dcoughlin, MaskRay. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a reviewer: george.karpenkov. Fix for the bug n°39792: False positive on strcpy targeting