[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

This revision was automatically updated to reflect the committed changes. Closed by commit rL349986: [gn build] Add build files for clang/lib/{ASTMatchers,CrossTU}… (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55978/new/ https://reviews.llvm.org/D55978 ___ cfe-commits mailing list

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis added a comment. In D55978#1338651 , @george.karpenkov wrote: > Looks reasonable, what about linking with Z3? Or is your goal just to get a > minimally working functionality? Sorry, forgot to reply to this. I don't use this, so I feel someone

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis added a comment. Thanks for taking a look! In D55978#1338654 , @george.karpenkov wrote: > > I might want to default to clang_enable_static_analyzer=false when I add > > the clang/lib/FrontendTool build file. > > I don't think that quite makes

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

george.karpenkov added a comment. > I might want to default to clang_enable_static_analyzer=false when I add the > clang/lib/FrontendTool build file. I don't think that quite makes sense, since by default clang does have the analyzer built in. CHANGES SINCE LAST ACTION

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

george.karpenkov added a comment. Looks reasonable, what about linking with Z3? Or is your goal just to get a minimally working functionality? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55978/new/ https://reviews.llvm.org/D55978 ___

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: dkrupp, donat.nagy, jfb, Szelethus, arphaman, a.sidorin, baloghadamsoftware. Herald added a reviewer: george.karpenkov. The intent is to add the build file for clang/lib/StaticAnalyzer/Frontend; everything