[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

This revision was automatically updated to reflect the committed changes. Closed by commit rL352084: Add a priority field to availability attributes to prioritize explicit (authored by arphaman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a suggested edit for the docs (which look great, btw!). Comment at: include/clang/Basic/AttrDocs.td:1252 + +For platforms like ``watchOS`` and ``tvOS`` whose availability attributes can +be

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56892/new/ https://reviews.llvm.org/D56892

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman added a comment. In D56892#1363089 , @aaron.ballman wrote: > I think the documentation for the attribute should be updated to explain this > new behavior, otherwise this will be a very inexplicable feature to users. Done > One question I

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman updated this revision to Diff 182608. arphaman marked 3 inline comments as done. arphaman added a comment. - Add documentation and expand a comment as suggested by Aaron. - Address Erik's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56892/new/

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

erik.pilkington added a comment. This seems pretty reasonable to me. I agree that a more general mechanism to override #pca (/implicit) attributes would be pretty useful, but I guess there is no need to jump the gun on that. Comment at: include/clang/Sema/Sema.h:2471 +

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

aaron.ballman added a comment. I think the documentation for the attribute should be updated to explain this new behavior, otherwise this will be a very inexplicable feature to users. One question I have is: will this feature also be needed by other attributes? This seems like a somewhat

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman updated this revision to Diff 182432. arphaman added a comment. Reverse the priority numbering direction as suggested by @dexonsmith . Now the lower priority is the most important, and the less important priorities have a higher numerical value. Repository: rC Clang CHANGES SINCE

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: dexonsmith, jkorous. We have an issue when using `#pragma clang attribute` with availability attributes: - The explicit attribute that's specified next to the declaration is not