[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

sammccall added a comment. Herald added a subscriber: ormris. Renamed in rL368455 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57165/new/ https://reviews.llvm.org/D57165 ___

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

thakis added a comment. Herald added a project: clang. A few weeks later, I realize that since the test doesn't have a ".test" extension, it doesn't run on any bots. Could you rename it to leakfiles.test (or any other fitting extension listed in clang/test/lit.cfg.py's config.suffixes list)?

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

This revision was automatically updated to reflect the committed changes. Closed by commit rC352079: [FileManager] Revert r347205 to avoid PCH file-descriptor leak. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D57165?vs=183340=183347#toc

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

sammccall updated this revision to Diff 183340. sammccall marked an inline comment as done. sammccall added a comment. avoid revert of fillRealPathName() (thanks Nico!) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57165/new/ https://reviews.llvm.org/D57165

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm, but lebtm with call to fillRealPathName() Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57165/new/ https://reviews.llvm.org/D57165

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

thakis added inline comments. Comment at: lib/Basic/FileManager.cpp:295 + llvm::sys::path::remove_dots(AbsPath, /*remove_dot_dot=*/true); + UFE.RealPathName = AbsPath.str(); +} Should this call fillRealPathName() (which was added after your

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

sammccall created this revision. sammccall added reviewers: bkramer, thakis. Herald added subscribers: cfe-commits, kadircet, ioeric, ilya-biryukov. r347205 fixed a bug in FileManager: first calling getFile(shouldOpen=false) and then getFile(shouldOpen=true) results in the file not being open.