This revision was automatically updated to reflect the committed changes.
Closed by commit rC352799: [CUDA] add support for the new kernel launch API in
CUDA-9.2+. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57488?vs=184592=184598#toc
Repository:
rC
tra updated this revision to Diff 184592.
tra added a comment.
Updated ASTMatchers unit test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57488/new/
https://reviews.llvm.org/D57488
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
tra added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:239
+CGM.Error(CGF.CurFuncDecl->getLocation(),
+ "Can't find declaration for cudaLaunchKernel()"); // FIXME.
+return;
jlebar wrote:
> Unfixed FIXME?
Fixed the comment. :-)
tra updated this revision to Diff 184543.
tra marked 8 inline comments as done.
tra edited the summary of this revision.
tra added a comment.
Addressed Justin's comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57488/new/
https://reviews.llvm.org/D57488
Files:
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
LGTM, mostly nits.
Comment at: clang/include/clang/Sema/Sema.h:10316
+ /// Returns the name of the launch configuration function.
+ std::string
tra created this revision.
tra added a reviewer: jlebar.
Herald added subscribers: bixia, sanjoy.
Instead of calling CUDA runtime to arrange function arguments,
the new API constructs arguments in a local array and the kernels
are launched with __cudaLaunchKernel().
The old API has been
