[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL352881: [CMake] External compiler-rt-configure requires LLVMTestingSupport when… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

mgorny added a comment. Ideally we wouldn't introduce such a complex dependency for 2 test cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 ___ cfe-commits mailing list

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

sgraenitz added a comment. In D57521#1379837 , @beanz wrote: > @phosek, does LLVM’s runtime directory do this correctly? > > At some point we should try and deprecate and remove this option in favor of > the LLVM directory because the LLVM approach is

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

beanz added a reviewer: phosek. beanz added a subscriber: phosek. beanz added a comment. Herald added a project: clang. @phosek, does LLVM’s runtime directory do this correctly? At some point we should try and deprecate and remove this option in favor of the LLVM directory because the LLVM

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 ___

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

sgraenitz added a comment. FYI: Seems to be happening since D55891 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 ___ cfe-commits mailing

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

sgraenitz updated this revision to Diff 184531. sgraenitz added a comment. Polishing Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 Files: runtime/CMakeLists.txt Index: runtime/CMakeLists.txt

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

sgraenitz created this revision. sgraenitz added reviewers: ab, beanz. Herald added subscribers: erik.pilkington, mgorny, dberris. Apparently `LLVMTestingSupport` must be built before `llvm-config` can be asked for it. Symptom with `LLVM_INCLUDE_TESTS=ON` is: $