kkwli0 closed this revision.
kkwli0 added a comment.
Committed: r353186
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57690/new/
https://reviews.llvm.org/D57690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57690/new/
https://reviews.llvm.org/D57690
___
cfe-commits mailing list
kkwli0 updated this revision to Diff 185125.
kkwli0 marked an inline comment as done.
kkwli0 added a comment.
Update based on review comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57690/new/
https://reviews.llvm.org/D57690
Files:
clang/lib/Sema/SemaOpenMP.cpp
kkwli0 marked 2 inline comments as done.
kkwli0 added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:7070
const auto *OED = dyn_cast(*I);
-if (!OED || !isOpenMPTeamsDirective(OED->getDirectiveKind())) {
+if (!OED ||
ABataev added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:7070
const auto *OED = dyn_cast(*I);
-if (!OED || !isOpenMPTeamsDirective(OED->getDirectiveKind())) {
+if (!OED || !isOpenMPTeamsDirective(OED->getDirectiveKind()) ||
+
kkwli0 created this revision.
kkwli0 added a reviewer: ABataev.
Herald added a subscriber: guansong.
The compiler does not generate any error messages if there are more than one
teams construct inside a target constructs.
#pragma omp target
{
#pragma omp teams
{ ... }
