[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

2019-10-30 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl reclaimed this revision. yaxunl added a comment. we still need this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

2019-09-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl abandoned this revision. yaxunl marked an inline comment as done. yaxunl added a comment. no longer needed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 ___ cfe-commits mailing list

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

2019-02-07 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Also, why is this HIP-specific? I thought the toolchain was largely shared with CUDA and there were just a few runtime differences. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

2019-02-06 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D57829#1387416 , @yaxunl wrote: > In D57829#1387412 , @tra wrote: > > > Could you elaborate on why you want to disable this metadata? I think the > > original idea of llvm.linker.options

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

2019-02-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D57829#1387412 , @tra wrote: > Could you elaborate on why you want to disable this metadata? I think the > original idea of llvm.linker.options was that it should be ignored if the > back-end does not support it. If backend

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

2019-02-06 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Could you elaborate on why you want to disable this metadata? I think the original idea of llvm.linker.options was that it should be ignored if the back-end does not support it. Comment at: lib/CodeGen/CodeGenModule.cpp:441 if (CodeGenOpts.Autolink &&

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

2019-02-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. HIP toolchain does not support llvm.linker.options in device compilation, therefore disable it. https://reviews.llvm.org/D57829 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCUDA/linker-options.cu Index: