[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

2019-02-13 Thread Goran Mitrovic via Phabricator via cfe-commits
gmit added a comment. Sorry, this is my first LLVM commit, so I don't really know the procedure. There is no test as it cannot be reproduced. The crash caused by this was spotted in one of our customer's crash dumps. The added condition should be obvious as it is tested in the assert just

[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

2019-02-13 Thread Goran Mitrovic via Phabricator via cfe-commits
gmit updated this revision to Diff 186675. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58178/new/ https://reviews.llvm.org/D58178 Files: RawStringLiteralCheck.cpp

[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

2019-02-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. 1. test? 2. please always upload all patches with full context (`-U9`) 3. The diff is malformed. `RawStringLiteralCheck.cpp` is not on the top level of the repo Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

2019-02-13 Thread Goran Mitrovic via Phabricator via cfe-commits
gmit created this revision. gmit added a reviewer: alexfh. gmit added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. isRawStringLiteral will read from memory randomly if double quote is not found. Repository: rCTE Clang Tools Extra