This revision was automatically updated to reflect the committed changes.
Closed by commit rL356185: Add PragmaHandler for MSVC pragma
execution_character_set (authored by rnk, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
thakis accepted this revision.
thakis added a comment.
Ah ok, then I agree this doesn't need serialization yet :)
It'd be nice to at least diag that the stack use is valid (also for the warning
stack), but it doesn't have to be in this change.
CHANGES SINCE LAST ACTION
sigatrev added a comment.
This implementation doesn't track the push/pop stack, it just verifies the
synax is valid and moves on. I modeled it after the PragmaWarningHandler which
does the same, and thought it would be fine in this case since the only
accepted value is a no-op.
CHANGES SINCE
thakis added a comment.
Does our serialization machinery serialize these correctly automatically? What
happens if you compiler a header saying `execution_character_set_push,
"utf-8")` in a header, compile that to a pch, then include that through the pch
in a .c file that does pop?
My guess is
sigatrev added a comment.
Yeah, that would be great. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58530/new/
https://reviews.llvm.org/D58530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks! Would you like someone to land this for you?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58530/new/
https://reviews.llvm.org/D58530
sigatrev updated this revision to Diff 189629.
sigatrev added a comment.
Added tests, and slightly improved associated messaging.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58530/new/
https://reviews.llvm.org/D58530
Files:
clang-tools-extra/pp-trace/PPCallbacksTracker.cpp
rnk added a comment.
Looks good and thorough, but it needs tests.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58530/new/
https://reviews.llvm.org/D58530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sigatrev created this revision.
sigatrev added reviewers: cfe-commits, rnk.
Herald added subscribers: jdoerfert, jsji, kbarton, nemanjai.
Herald added a project: clang.
__pragma(execution_character_set(push, "UTF-8")) is used in
TraceLoggingProvider.h. This commit
implements a no-op handler for
