[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked 3 inline comments as done. Closed by commit rC356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library (authored by hubert.reinterpretcast, committed by ). Changed prior to

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

asb added a comment. In D59233#1439656 , @hubert.reinterpretcast wrote: > Thanks @xingxue for the review. I will update for the error handling before > committing. Use of report_fatal_error/llvm_unreachable isn't fully consistent within the LLVM

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. Herald added a subscriber: jsji. Thanks @xingxue for the review. I will update for the error handling before committing. Comment at: tools/libclang/CIndexer.cpp:61 +if (errno

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added subscribers: asb, majnemer, lhames. hubert.reinterpretcast added a comment. @asb @lhames @majnemer, based on D36826 , I believe that your guidance would be helpful here regarding the use of `llvm_unreachable`, `report_fatal_error`,

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59233/new/ https://reviews.llvm.org/D59233 ___

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added a comment. I believe that the conditions being checked for with `llvm_unreachable` in this patch are of the debug-only variety; however, some input would be appreciated regarding the choice of using `llvm_unreachable` instead of `report_fatal_error` or `assert`.

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, xingxue, jasonliu. Herald added a subscriber: arphaman. Herald added a project: clang. `dladdr` is not available on AIX. Similar functionality is presented through `loadquery`. This patch replaces a