[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin added a comment. I am not sure what you mean by "break". Can you share a reproducer? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/ https://reviews.llvm.org/D59415 ___ cfe-commits mailing list

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

johan-boule added a comment. Is this going to break symlinks on Windows? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/ https://reviews.llvm.org/D59415 ___ cfe-commits mailing list

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361598: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on… (authored by ikudrin, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! This looks good to me. I'm still a bit nervous about "mklink" in the test, but let's land this and see if the bots can handle it. CHANGES SINCE LAST ACTION

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin updated this revision to Diff 200749. ikudrin edited the summary of this revision. ikudrin added a comment. Added a comment explaining the differences in the implementations. I would really appreciate any corrections. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans added inline comments. Comment at: lib/Frontend/TextDiagnostic.cpp:768 if (Dir) { +#ifdef _WIN32 + SmallString<4096> DirName = Dir->getName(); I think this requires a comment explaining why Windows is handled differently. CHANGES SINCE LAST

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin updated this revision to Diff 200252. ikudrin added a comment. - Made the patch affect only `-fdiagnostics-absolute-paths` option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/ https://reviews.llvm.org/D59415 Files: lib/Frontend/TextDiagnostic.cpp

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans added a comment. I don't feel like I have enough background on what you're trying to do to review this. It sounds related to clangd issues maybe? "If the source file path contains directory junctions, and we resolve them when printing diagnostic messages" I didn't think Clang tried to

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin added a comment. Ping. Please note, that, in contrary to POSIX OSes, on Windows a path like `dir1\\..` refers to `dir1`. That's why we do not need to ask the system for the fully expanded path and can do all calculations internally. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin marked an inline comment as done. ikudrin added inline comments. Comment at: test/Frontend/absolute-paths-windows.test:4 +// RUN: mkdir -p %t.dir\real +// RUN: cmd /c mklink /j %t.dir\junc %t.dir\real +// RUN: echo "wrong code" > %t.dir\real\foo.cpp

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin marked an inline comment as done. ikudrin added inline comments. Comment at: test/Frontend/absolute-paths-windows.test:4 +// RUN: mkdir -p %t.dir\real +// RUN: cmd /c mklink /j %t.dir\junc %t.dir\real +// RUN: echo "wrong code" > %t.dir\real\foo.cpp hans

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans added inline comments. Comment at: test/Frontend/absolute-paths-windows.test:4 +// RUN: mkdir -p %t.dir\real +// RUN: cmd /c mklink /j %t.dir\junc %t.dir\real +// RUN: echo "wrong code" > %t.dir\real\foo.cpp This requires (a recent version of) Win 10 or

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin created this revision. ikudrin added reviewers: ioeric, bkramer, hans, thakis, rsmith, zturner. Herald added a project: clang. This patch partially reverts D46942 . If the source file path contains directory junctions, and we resolve them when printing