[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. In D59985#1454676 , @Anastasia wrote: > In D59985#1454660 , @AlexeySotkin > wrote: > > > In D59985#1454629 , @Anastasia > > wrote: > > > > >

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Anastasia added a comment. In D59985#1454660 , @AlexeySotkin wrote: > In D59985#1454629 , @Anastasia wrote: > > > In D59985#1453312 , @AlexeySotkin > > wrote: > > > > >

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. In D59985#1454629 , @Anastasia wrote: > In D59985#1453312 , @AlexeySotkin > wrote: > > > Alternative way to fix it is to use `isNullPointerConstant` like we do in > >

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Anastasia added a comment. In D59985#1453312 , @AlexeySotkin wrote: > Alternative way to fix it is to use `isNullPointerConstant` like we do in > `SemaOpenCLBuiltinEnqueueKernel`. So in case we have a zero literal value we > can emit

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. Alternative way to fix it is to use `isNullPointerConstant` like we do in `SemaOpenCLBuiltinEnqueueKernel`. So in case we have a zero literal value we can emit `ConstantPointerNull` directly, without `EmitScalarExpr` . Repository: rC Clang CHANGES SINCE LAST

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + : Builder.CreatePointerCast(EventList, EventPtrTy);

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + : Builder.CreatePointerCast(EventList, EventPtrTy);

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl. Herald added subscribers: cfe-commits, ebevhan, kristina. Herald added a project: clang. https://reviews.llvm.org/D53809 fixed wrong address space(assert in debug build) generated for `event_ret` argument. But