[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 added a comment. Thank you, I submitted a clang-formatted fix for the if statement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mailing list cfe-commi

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra added a comment. In D60141#1452019 , @ashi1 wrote: > Hi Artem, I had just committed the change. IS this change OK or should I > revert it? The `if` condition could use some clang-formatting, but other than that the patch still looks OK to me. Rep

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 added a comment. Hi Artem, I had just committed the change. IS this change OK or should I revert it? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mail

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

This revision was automatically updated to reflect the committed changes. Closed by commit rL357526: [HIP-Clang] Fat binary should not be produced for non GPU code 2 (authored by aaronenyeshi, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra accepted this revision. tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP && EmittedKernels.empty() && DeviceVars.empty()) +return nullptr; // void __{cuda|hip}_register_globals(void* handle); yax

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

yaxunl added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP && EmittedKernels.empty() && DeviceVars.empty()) +return nullptr; // void __{cuda|hip}_register_globals(void* handle); tra wrote: > I think this wo

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra added a comment. General nit: please use diffs with very large context when you submit patches with Phabricator. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-c

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not produce Fat binary functions for HIP when no device code is present. Repository: rC Clang https://reviews.llvm.org/D60141 Files: lib/CodeGen/CGCUDANV.c