[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-12 Thread Don Hinton via Phabricator via cfe-commits
hintonda abandoned this revision. hintonda added a comment. Replaced by D60629 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60151/new/ https://reviews.llvm.org/D60151

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D60151#1463484 , @MyDeveloperDay wrote: > >> I suppose we could keep the names and directory structure and just change > >> the namespace. That would just be a special case in the scripts. Haven't > >> looked into it yet,

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. >> I suppose we could keep the names and directory structure and just change >> the namespace. That would just be a special case in the scripts. Haven't >> looked into it yet, but will do so as soon as I can. > > Isn't that matching done on strings? I.e. is

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D60151#1462976 , @hintonda wrote: > In D60151#1462850 , @MyDeveloperDay > wrote: > > > are we supporting "-llvm-*" in existing .clang-tidy files? > > > > If people selectively turn

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D60151#1462850 , @MyDeveloperDay wrote: > are we supporting "-llvm-*" in existing .clang-tidy files? > > If people selectively turn checkers off, won't all of a sudden everyone start > getting llvm-project checks and fixes

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. are we supporting "-llvm-*" in existing .clang-tidy files? If people selectively turn checkers off, won't all of a sudden everyone start getting llvm-project checks and fixes turned back on? https://github.com/search?q=-llvm-%2A=Code maybe we need to add

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D60151#1454802 , @hintonda wrote: > In D60151#1454741 , @alexfh wrote: > > > In D60151#1454105 , @hintonda > > wrote: > > > > > - Rename

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D60151#1454741 , @alexfh wrote: > In D60151#1454105 , @hintonda wrote: > > > - Rename llvm directory to llvm_project. > > - Change llvm- to llvm-project-. > > - Rename files. > > >

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

2019-04-04 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In D60151#1454105 , @hintonda wrote: > - Rename llvm directory to llvm_project. > - Change llvm- to llvm-project-. > - Rename files. Awesome! Thanks for doing this. Could you ensure that the add_new_check.py script still works?