[PATCH] D60203: Updating Chromium's Java import order

2019-04-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC357700: Updating Chromiums Java import order (authored by nico, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203

[PATCH] D60203: Updating Chromium's Java import order

2019-04-04 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Ah, ok. Probably want to add tests at some point, but I'll land this as-is for now then. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___

[PATCH] D60203: Updating Chromium's Java import order

2019-04-04 Thread Sam Maier via Phabricator via cfe-commits
SamMaier added a comment. In D60203#1453313 , @thakis wrote: > Thanks! > > (Test?) We currently don't have tests for Chromium's specific Java import order. The tests for Java import order use their own order. Should this change? Repository: rC

[PATCH] D60203: Updating Chromium's Java import order

2019-04-03 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! (Test?) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___

[PATCH] D60203: Updating Chromium's Java import order

2019-04-03 Thread Sam Maier via Phabricator via cfe-commits
SamMaier created this revision. SamMaier added a reviewer: thakis. Herald added subscribers: cfe-commits, srhines. Herald added a project: clang. Adding in androidx as another import group. Repository: rC Clang https://reviews.llvm.org/D60203 Files: lib/Format/Format.cpp Index: