[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL368979: [analyzer] Add docs for cplusplus.InnerPointer (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added a comment. Cute!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60281/new/ https://reviews.llvm.org/D60281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added a comment. In D60281#1630646 , @NoQ wrote: > Thanks! > > One more quick question: Who is Husi??? Well thats me. Long story short, the reason why my name is Szelethus is that my first ever character to hit max level in World of Warcraft

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! One more quick question: Who is Husi??? Comment at: clang/docs/analyzer/checkers.rst:261 + + void consume(const char *); + This declaration doesn't add

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus updated this revision to Diff 215288. Szelethus marked 2 inline comments as done. Szelethus added a comment. Fixed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60281/new/ https://reviews.llvm.org/D60281 Files: clang/docs/analyzer/checkers.rst Index:

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added inline comments. Comment at: clang/docs/analyzer/checkers.rst:263 + + void _deref_after_equals() { + std::string s = "llvm"; I suggest `deref_after_assignment`. Comment at: clang/docs/analyzer/checkers.rst:271 + const char

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus updated this revision to Diff 215281. Szelethus changed the repository for this revision from rC Clang to rG LLVM Github Monorepo. Szelethus added a comment. Revised the documentation according to @NoQ's comments. By literally copy pasting it. Like any good programmer should do :^)

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

rnkovacs added a comment. In D60281#1630337 , @Szelethus wrote: > I'll gladly add the finishing touches :) So sorry for leaving this hanging! Thanks Husi, you da best :) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus commandeered this revision. Szelethus edited reviewers, added: rnkovacs; removed: Szelethus. Szelethus added a comment. This revision now requires review to proceed. I'll gladly add the finishing touches :) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most notably,

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

dkrupp added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Woohoo! Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

rnkovacs created this revision. rnkovacs added reviewers: NoQ, xazax.hun, Szelethus, dcoughlin, dkrupp. Herald added subscribers: cfe-commits, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Tried to pick two