[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

This revision was automatically updated to reflect the committed changes. Closed by commit rL358642: Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax) (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Herald added a project:

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mclow.lists added a comment. I have no problem with this. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60417/new/ https://reviews.llvm.org/D60417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. I'm relaying approval to @mstorsjo, who seems okay with the change. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60417/new/

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mstorsjo added a comment. In D60417#1464070 , @mstorsjo wrote: > In D60417#1459249 , @mstorsjo wrote: > > > Given that, the suggested form of this patch is indeed correct - sorry for > > the noise. > > > > I can

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mstorsjo added a comment. In D60417#1459249 , @mstorsjo wrote: > Given that, the suggested form of this patch is indeed correct - sorry for > the noise. > > I can commit the patch for you, but I'd need approval by either of @EricWF, > @ldionne or

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mstorsjo added a comment. In D60417#1459128 , @jeremfg wrote: > In D60417#1458778 , @mstorsjo wrote: > > > The change looks sensible to me, but should we maybe even skip the `#if` > > altogether? If the files uses

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

jeremfg added a comment. In D60417#1458778 , @mstorsjo wrote: > The change looks sensible to me, but should we maybe even skip the `#if` > altogether? If the files uses unified syntax and can't be parsed in thumb > mode otherwise, there's maybe no need

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mstorsjo added reviewers: ldionne, EricWF, mclow.lists. mstorsjo added a comment. Herald added a subscriber: dexonsmith. The change looks sensible to me, but should we maybe even skip the `#if` altogether? If the files uses unified syntax and can't be parsed in thumb mode otherwise, there's

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

jeremfg created this revision. jeremfg added a reviewer: mstorsjo. Herald added subscribers: libcxx-commits, ldionne, kristof.beyls, javed.absar. I'm a first time contributor to LLVM... While attempting to compile the assembly files ( .S) for a Cortex-M4 device using GCC's arm-none-eabi, I