This revision was automatically updated to reflect the committed changes.
Closed by commit rC358200: Add support for attributes on @implementations in
Objective-C (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D60542?vs=194594&id=194716#toc
Repository:
aaron.ballman added inline comments.
Comment at: clang/test/FixIt/fixit-pragma-attribute.cpp:19-20
#pragma clang attribute push
(__attribute__((annotate("subRuleContradictions"))), apply_to = any(variable,
variable(is_parameter), function(is_member), variable(is_global)))
-//
erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.
Comment at: clang/test/FixIt/fixit-pragma-attribute.cpp:19-20
#pragma clang attribute push
(__attribute__((annotate("subRuleContradictions"))), apply_to = any(variable,
variable(is_paramet
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from a question.
Comment at: clang/test/FixIt/fixit-pragma-attribute.cpp:19-20
#pragma clang attribute push
(__attribute__((annotate("subRuleContradictions"))), apply_to = any(variable,
variable(
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60542/new/
https://reviews.llvm.org/D60542
___
cfe-commi
erik.pilkington created this revision.
erik.pilkington added reviewers: aaron.ballman, rjmccall.
Herald added subscribers: dexonsmith, jkorous.
Herald added a project: clang.
We want to make `objc_nonlazy_class` apply to implementations, but ran into
this. There doesn't seem to be any reason that
