[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358719: [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D60732#1469026 , @jdenny wrote: > The original patch added documentation to `-cc1 -help`. Doxygen for > VerifyDiagnosticConsumer is another possibility except it currently doesn't > mention command-line usage at all. Maybe it

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-16 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D60732#1469026 , @jdenny wrote: > Sometimes you can avoid an explosion of FileCheck prefixes using -D. I'm not > aware of anything like -D for -verify. I mean a -D that expands a variable within an expected diagnostic.

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-16 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. > Just wanted to give a bit more visibility to the underrated technology of > writing -verify=a,b,c instead of the #ifdefclutter. It's great to see this getting more use. > It's also a bit wonky because it seems that you have to write an exponential > number of flags

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-15 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. This is also very useful to test that a given warning is only emitted in c++xx. Funnily when grepping for `verify=` in `test/` most matches are from tests exercising this functionality. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-15 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I think this functionality is unused because you would split the file into six to reduce the overhead/scroll and that is it. It is a cool reveal, could you provide a documentation?

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

2019-04-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso, jdenny. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Just wanted to give a bit more