[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ilya-biryukov wrote: > ymandel wrote: >

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ymandel wrote: > ilya-biryukov wrote: > > ymandel wrote: > > >

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361418: [clang-tidy] Add support for writing a check as a Transformer rewrite rule. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D61386?vs=200802=200804#toc

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200802. ymandel removed a subscriber: dexonsmith. ymandel added a comment. Replace previous diff which had the wrong base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ilya-biryukov wrote: > ymandel wrote: >

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ymandel wrote: >

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. In D61386#1510690 , @MyDeveloperDay wrote: > Just a passing comment, Is this: > > a) a different type of check that would be used for a different type of check > than previous clang-tidy checks > b) or is this a replacement on

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

MyDeveloperDay added a comment. Just a passing comment, Is this: a) a different type of check that would be used for a different type of check than previous clang-tidy checks b) or is this a replacement on the previous style? Is there any documentation about the benefits of this method vs the

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 4 inline comments as done. ymandel added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200536. ymandel added a comment. Renamed TransformerTidy to TransformerClangTidyCheck; classes and files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files:

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:32 +// }; +class TransformerTidy : public ClangTidyCheck { +public: ymandel wrote: > gribozavr wrote: > > I'd prefer a name like "TransformerClangTidyCheck", it

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:32 +// }; +class TransformerTidy : public ClangTidyCheck { +public: gribozavr wrote: > I'd prefer a name like

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.h:32 +// }; +class TransformerTidy : public ClangTidyCheck { +public: I'd prefer a

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. Ping. Is anyone willing to be the reviewer for this revision? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200072. ymandel added a comment. Updated to incorporate changes to Transformer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files:

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ilya-biryukov added a comment. @aaron.ballman, would be a good reviewer for this? I'm happy to look at the transformer bits, but I'm definitely the wrong one to asses it from the `clang-tidy` perspective. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked an inline comment as done. ymandel added a comment. In D61386#1487735 , @JonasToth wrote: > I like the new framework! Great! Comment at: clang-tools-extra/unittests/clang-tidy/TransformerTidyTest.cpp:38 +

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197836. ymandel marked 2 inline comments as done. ymandel added a comment. responded to comments and shortened (unnecessarily long) variable name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

JonasToth added a comment. I like the new framework! Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:43 + if (Rule.Explanation) { +if (Expected Explanation = Rule.Explanation(Result)) { + Message = *Explanation; these if-else are

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:51 + DiagnosticBuilder Diag = diag(RootLoc, Message); + for (const tooling::Transformation : *Transformations) { +Diag <<

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197597. ymandel marked an inline comment as done. ymandel added a comment. reinstated an auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files:

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:51 + DiagnosticBuilder Diag = diag(RootLoc, Message); + for (const tooling::Transformation : *Transformations) { +Diag << FixItHint::CreateReplacement(T.Range,

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:22 + // Verify the existence and validity of the AST node that roots this rule. + auto = Result.Nodes.getMap(); + auto Root =

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197589. ymandel added a comment. Reduced use of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files: clang-tools-extra/clang-tidy/utils/CMakeLists.txt

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:22 + // Verify the existence and validity of the AST node that roots this rule. + auto = Result.Nodes.getMap(); + auto Root = NodesMap.find(tooling::RewriteRule::RootId);

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel created this revision. ymandel added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This revision introduces an adaptor from Transformer's rewrite rules (`clang::tooling::RewriteRule`) to `ClangTidyCheck`. For example,