This revision was automatically updated to reflect the committed changes.
Closed by commit rL360474: [CodeGen][ObjC] Emit invoke instead of call to call
`objc_release` when (authored by ahatanak, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61803/new/
https://reviews.llvm.org/D61803
ahatanak updated this revision to Diff 199081.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Just call `EmitCallOrInvoke`.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61803/new/
https://reviews.llvm.org/D61803
Files:
erik.pilkington added inline comments.
Comment at: lib/CodeGen/CGObjC.cpp:2634-2646
+ ASTContext = getContext();
+ const ImplicitParamDecl *paramDecl =
+ ImplicitParamDecl::Create(Ctx, nullptr, SourceLocation(), nullptr,
+Ctx.VoidPtrTy,
ahatanak created this revision.
ahatanak added reviewers: pete, rjmccall.
ahatanak added a project: clang.
Herald added subscribers: dexonsmith, jkorous.
Prior to r349952, clang used to call `objc_msgSend` when sending a release
messages, emitting an invoke instruction instead of a call
