yonghong-song added a comment.
@rsmith @eli.friedman Thanks for your comments. I fully agree that it seems
awkward that we have both GEP and intrinsic generation. I will try to do some
experiments here to only have intrinsic generation. My only concern is possible
performance degradation. I
efriedma added a comment.
> The size you allocate here will presumably need to vary as the struct layout
> changes, and you have no way of knowing which allocas will need their sizes
> to be changed.
Your example is just a pointer; the size of a pointer won't change.
That said, yes, address
rsmith added a comment.
If I understand correctly, you want to be able to compile a program against
some `struct` and `union` layouts, and then at load time "update" the program
to cope with the actual layouts for those types being something else, but
containing (at least) the set of members
yonghong-song added a comment.
@lebedev.ri Thanks for the comment. This patch is not ready to land yet. Yes,
tests are missing and I am going to add tests later.
More importantly, I want to get a sense whether what I am implementing here is
the right direction or not.
The following two other
lebedev.ri added a comment.
Tests seems to be missing?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61809/new/
https://reviews.llvm.org/D61809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yonghong-song created this revision.
yonghong-song added reviewers: eli.friedman, ast.
Herald added subscribers: cfe-commits, arphaman, kosarev.
Herald added a project: clang.
For background of BPF CO-RE project, please refer to
http://vger.kernel.org/bpfconf2019.html
In summary, BPF CO-RE