[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. Almost there. I think everything looks good after we resolve this last round of comments. Can you also update the commit description. I believe that the current

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200401. yaqiji added a comment. Simplified method signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200399. yaqiji marked 2 inline comments as done. yaqiji added a comment. Herald added a subscriber: mgorny. Modified CMakeList to include tests, otherwise clangTidyGoogleModule wouldn't compile. Added k_Alpha test case back. Added Extern case so that if it

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:45 + + auto NewName = (IsConst? "k": "g") + llvm::StringRef(std::string(1, FC)).upper()) + + Decl->getName().substr(1).str());

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200113. yaqiji marked an inline comment as done. yaqiji added a comment. Added fixithint for const as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit. Comment at:

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200102. yaqiji added a comment. Updated matching criteria to allow variable declarations for legacy code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:51-52 + + auto NewName = "g" +

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:51-52 + + auto NewName = "g" + llvm::StringRef(std::string(1,

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 199944. yaqiji added a comment. Changes matcher, test and removed fix it hint for global constants Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files:

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 199939. yaqiji added a comment. Modified code to make it more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: