[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

This revision was automatically updated to reflect the committed changes. Closed by commit rL361461: [CodeComplete] Complete a lambda when preferred type is a function (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov updated this revision to Diff 200876. ilya-biryukov added a comment. - Remove a leftover from name check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62238/new/ https://reviews.llvm.org/D62238 Files:

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4142 + // Handle other cases. + if (T->isPointerType()) +T

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) + return nullptr; kadircet wrote: > ilya-biryukov wrote: > >

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov updated this revision to Diff 200745. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Only work on sugared types - Do not check for 'function' in the name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) + return nullptr; ilya-biryukov wrote: > kadircet wrote: > > This looks

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov marked an inline comment as done and an inline comment as not done. ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) +

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov updated this revision to Diff 200717. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Add placeholder for captures. - Only accept classes that have exactly one template argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) + return nullptr; This looks cheesy, do we really want to perform this

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: clang. Uses a heuristic to detect std::function and friends. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62238 Files: clang/lib/Sema/SemaCodeComplete.cpp