[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2020-07-24 Thread Jeroen Dobbelaere via Phabricator via cfe-commits
jeroen.dobbelaere added a comment. Herald added a subscriber: dang. Found some issue when looking at this code: -ftrapping_math and -fno_trapping_math will never have effect Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3155 + if (Args.hasArg(OPT_ftrapping_math)) {

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-26 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D62731#1796962 , @AntonYudintsev wrote: > I have found bug in clang-cl (win32 clang), related to recent inroduction of > ffp-exception-behavior. > Unfortunately, I don't have a working patch yet, and since LLVM

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-26 Thread Eric Christopher via cfe-commits
You can sign up for an account by emailing the admin account. On Thu, Dec 26, 2019, 5:04 PM Anton Yudintsev via Phabricator < revi...@reviews.llvm.org> wrote: > AntonYudintsev added a comment. > > I have found bug in clang-cl (win32 clang), related to recent inroduction > of

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-26 Thread Anton Yudintsev via Phabricator via cfe-commits
AntonYudintsev added a comment. I have found bug in clang-cl (win32 clang), related to recent inroduction of ffp-exception-behavior. Unfortunately, I don't have a working patch yet, and since LLVM bugtracker registration is closed, I can not even submit a bug. So, if it is not a trouble for

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1790211 , @rupprecht wrote: > In D62731#1789122 , @rupprecht wrote: > > > In D62731#1788902 , > > @andrew.w.kaylor wrote: > > > > > In

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-18 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. In D62731#1789122 , @rupprecht wrote: > In D62731#1788902 , @andrew.w.kaylor > wrote: > > > In D62731#1788838 , @rupprecht > > wrote: > > > > >

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-17 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht closed this revision. rupprecht added a comment. In D62731#1788902 , @andrew.w.kaylor wrote: > In D62731#1788838 , @rupprecht wrote: > > > It seems the discussion of whether or not this is incomplete

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-17 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. In D62731#1788838 , @rupprecht wrote: > It seems the discussion of whether or not this is incomplete died out -- I'd > prefer to assume it is incomplete if there is no consensus. Mailed D71635 >

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-17 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename `-frounding-math` to `-fexperimental-rounding-math`. Alternatively we

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D62731#1784491 , @pengfei wrote: > >> It's good that people are looking at achieving better modeling for the x86 > >> backend, but we need to have a plan that doesn't require heroic effort > >> just to get basic

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-13 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added a comment. >> It's good that people are looking at achieving better modeling for the x86 >> backend, but we need to have a plan that doesn't require heroic effort just >> to get basic correctness. > > Do you mean in the backend? If so, I don't think that's possible. The >

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-13 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">,

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-13 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. In D62731#1784225 , @rjmccall wrote: > ... The big problem is that intrinsic calls are not arbitrary code: the vast > majority of intrinsics (e.g. all the ARM vector intrinsics, many of which can > be floating-point) are

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I believe your analysis on the second point is unfortunately missing half the problem. Functions like `fesetround` will be treated as having arbitrary side-effects by default, which mean arbitrary code can't be reordered with calls to them. It'd be good to model

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-13 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. In D62731#1782912 , @rjmccall wrote: > Hmm. The target-specific intrinsics thing does concern me, since I assume > many targets have a bunch of vector intrinsics that may be sensitive to > rounding. Do we have an idea

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D62731#1782897 , @andrew.w.kaylor wrote: > In D62731#1782762 , @rjmccall wrote: > > > Currently we emit a warning if you use `-frounding-math`, saying that the > > option is ignored.

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-12 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a comment. In D62731#1782762 , @rjmccall wrote: > Currently we emit a warning if you use `-frounding-math`, saying that the > option is ignored. That should have alerted users that they're not getting > the correct behavior now.

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Currently we emit a warning if you use `-frounding-math`, saying that the option is ignored. That should have alerted users that they're not getting the correct behavior now. This patch removes the warning and (IIUC) implements the correct behavior but is

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-12 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">,

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-12 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">,

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-12 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">, mibintc

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-12 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1780597 , @cameron.mcinally wrote: > I don't see a problem with this, but it would be nice to make the > `-f[no-]trapping-math` command line option work. GNU compatibility is good. Thanks Cameron, I'll go that way

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-11 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13047 + F->setUsesFPIntrin(true); + printf("Enclosing function uses fp intrinsics\n"); +} rupprecht wrote: > Looks like this is

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-11 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13047 + F->setUsesFPIntrin(true); + printf("Enclosing function uses fp intrinsics\n"); +} Looks like this is leftover debugging? I'm seeing log spam compiling some files -- this

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-11 Thread Cameron McInally via Phabricator via cfe-commits
cameron.mcinally added a comment. In D62731#1779872 , @mibintc wrote: > In D62731#1778597 , > @michele.scandale wrote: > > > >> I've noticed you removed the change for `CompilerInvocation.cpp` about > > >> the

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-11 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1778597 , @michele.scandale wrote: > >> I've noticed you removed the change for `CompilerInvocation.cpp` about the > >> initialization of the codegen option `NoTrappingMath`. Was that an > >> accident? Thanks again

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-10 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. In D62731#1775046 , @mibintc wrote: > In D62731#1773854 , > @michele.scandale wrote: > > > I've noticed you removed the change for `CompilerInvocation.cpp` about the > >

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-09 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1773854 , @michele.scandale wrote: > I've noticed you removed the change for `CompilerInvocation.cpp` about the > initialization of the codegen option `NoTrappingMath`. Was that an accident? I checked the old and new

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-06 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. I've noticed you removed the change for `CompilerInvocation.cpp` about the initialization of the codegen option `NoTrappingMath`. Was that an accident? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-05 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. I fixed the lit test problem and pushed it again commit 7f9b5138470db1dc58f3bc05631284c653c9ed7a Author: Melanie Blower Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-04 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. > It appears that only the 1st failure there is the fault of this patch. The > 2nd seems to have come from some openmp patch (that didn't consider dso_local > on windows). > > The first (fpconstrained.cpp) likely just needs the check-lines to NOT > explicitly say the

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-04 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D62731#1769532 , @thakis wrote: > The tests fail on Windows, http://45.33.8.238/win/3405/step_6.txt > > Please take a look, and if it takes a while to fix please revert while you > investigte. It appears that only the 1st

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-04 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. I reverted it again because build break on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing list

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-04 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. The tests fail on Windows, http://45.33.8.238/win/3405/step_6.txt Please take a look, and if it takes a while to fix please revert while you investigte. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-04 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked an inline comment as done. mibintc added a comment. I've pushed the updated patch, commit cdbed2dd856c14687efd741c2d8321686102acb8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2345 +<< "-ffp-contract=fast"; +optID = options::OPT_ffp_contract; +FPModel = Val; mibintc wrote: > michele.scandale wrote: > > Here the state

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:268 I->addAttribute(AttributeList::FunctionIndex, Attribute::StrictFP); -setConstrainedFPFunctionAttr(); } mibintc wrote: > @kpn I got rid of this line because the function

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 9 inline comments as done. mibintc added a comment. I added inline comments describing what I did in this version of the patch to address the bug https://bugs.llvm.org/show_bug.cgi?id=44048 Comment at: clang/include/clang/AST/DeclBase.h:1539 +/// Indicates

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-12-02 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 231758. mibintc added a comment. This commit was reverted in 30e7ee3c4bac because a null deref error occurred in IRBuilder.h when setting strictfp attribute, see

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-19 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2337 +<< "-ffp-contract=fast"; +optID = options::OPT_ffast_math; +FPModel = Val; Here it seems you are changing `optID` to `OPT_ffast_math` to

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-19 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2576 +CmdArgs.push_back("-ftrapping-math"); + } else if (TrappingMathPresent) CmdArgs.push_back("-fno-trapping-math"); mibintc wrote: > michele.scandale wrote: >

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-19 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 230128. mibintc added a comment. Here's an update in response to comments from @michele.scandale I fixed the assertion error and added a test case I fixed the setting of ftrapping-math in CodeGenOpts I deleted an incorrect comment I added a diagnostic when

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-19 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:262 Function *F = BB->getParent(); -if (!F->hasFnAttribute(Attribute::StrictFP)) { +if (F && !F->hasFnAttribute(Attribute::StrictFP)) { F->addFnAttr(Attribute::StrictFP);

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-19 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 4 inline comments as done. mibintc added a comment. inline replies to Michele, will upload a new patch shortly Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2408 +case options::OPT_frounding_math: + // The default setting for frounding-math is True

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-19 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:262 Function *F = BB->getParent(); -if (!F->hasFnAttribute(Attribute::StrictFP)) { +if (F && !F->hasFnAttribute(Attribute::StrictFP)) { F->addFnAttr(Attribute::StrictFP);

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2408 +case options::OPT_frounding_math: + // The default setting for frounding-math is True and ffast-math + // sets fno-rounding-math, but we only want to use constrained

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. In D62731#1750427 , @mibintc wrote: > In D62731#1750412 , @kpn wrote: > > > Does anyone think a warning is appropriate because the new flags are > > exercising experimental, incomplete code in

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:262 Function *F = BB->getParent(); -if (!F->hasFnAttribute(Attribute::StrictFP)) { +if (F && !F->hasFnAttribute(Attribute::StrictFP)) { F->addFnAttr(Attribute::StrictFP);

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1750412 , @kpn wrote: > Does anyone think a warning is appropriate because the new flags are > exercising experimental, incomplete code in both clang and llvm? The warning > would be removed when we believe the feature

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. Does anyone think a warning is appropriate because the new flags are exercising experimental, incomplete code in both clang and llvm? The warning would be removed when we believe the feature is complete and ready to use. Comment at:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. I added a nullptr check in IRBuilder.h and a test case to cover the segfault reported in https://bugs.llvm.org/show_bug.cgi?id=44048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 229893. mibintc added a reviewer: kpn. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Reopening since patch was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Eric Christopher via cfe-commits
No, it's just the bug that Jorge found. I understand it might have highlighted an existing bug, but reverting back to clean is the best bet here and then we can recommit when we get the latent bug fixed :) On Mon, Nov 18, 2019 at 11:08 AM Melanie Blower via Phabricator wrote: > > mibintc added a

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm working on a patch. Previously there was no support > > for frounding-math

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. The incorrect code is actually in the IRBuilder which is part of a different patch... In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. In D62731#1749916 , @mibintc wrote: > Thanks I see it, I'm working on a patch. Previously there was no support for > frounding-math (unimplemented). This patch enables the option. In the IR > builder, there's a call to a

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Eric Christopher via cfe-commits
Hi All, I've gone ahead and temporarily reverted here: echristo@jhereg ~/s/llvm-project> git push To github.com:llvm/llvm-project.git a77b66a0562..30e7ee3c4ba master -> master and we can just reapply when the issues are fixed. Thanks :) -eric On Mon, Nov 18, 2019 at 6:58 AM Melanie Blower

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. Thanks I see it, I'm working on a patch. Previously there was no support for frounding-math (unimplemented). This patch enables the option. In the IR builder, there's a call to a runtime function in the exception handler which is unexpectedly null. I start by adding a

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-18 Thread Jorge Gorbe Moya via Phabricator via cfe-commits
jgorbe added a comment. Hi, I found a clang crash that seems to be caused by this patch. Here's a reduced test case: template class a { public: ~a(); void b(); }; template a::~a() try { b(); } catch (...) { } class d { public: d(const char *, int);

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-11 Thread Melanie Blower via Phabricator via cfe-commits
mibintc closed this revision. mibintc added a comment. Don't know why the commit id didn't get linked when I pushed the change. Here's the closure info: commit af57dbf12e54f3a8ff48534bf1078f4de104c1cd Author: Melanie Blower

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Looks okay to me. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

2019-11-05 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 227960. mibintc retitled this revision from "Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior" to "Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and