[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363898: [analyzer] exploded-graph-rewriter: Implement a --diff mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 205443. NoQ added a comment. Don't try to sneak in an unrelated change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files: clang/test/Analysis/exploded-graph-rewriter/environment_diff.dot

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. Thanks for the main development! Could I start to reduce the size with my SVG-magic? What do you think about make it more SVG-based on the styling side? Comment at:

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:287 .replace('\\}', '}') \ +.replace('', '\\') \

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:287 .replace('\\}', '}') \ +.replace('', '\\') \

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 205177. NoQ added a comment. Add tests, rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files: clang/test/Analysis/exploded-graph-rewriter/environment_diff.dot

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:170-171 super(Store, self).__init__() -self.clusters = [StoreCluster(c) for c in json_s] +self.clusters =

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:170-171 super(Store, self).__init__() -self.clusters = [StoreCluster(c) for c in json_s] +self.clusters =

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added a comment. In D62761#1539143 , @NoQ wrote: > In D62761#1539137 , @Charusso wrote: > > > I asked for the new behavior, but I think it should be cool. > > > The new behavior is on the original

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ added a comment. In D62761#1539137 , @Charusso wrote: > I asked for the new behavior, but I think it should be cool. The new behavior is on the original screenshot, i just uploaded the wrong patch initially >.< CHANGES SINCE LAST ACTION

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I asked for the new behavior, but I think it should be cool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ added a comment. In D62761#1525923 , @Charusso wrote: > In D62761#1525917 , @NoQ wrote: > > > Remove "-" from program point dumps because it resembles a removal marker > > in diffs. > > > Could you add an

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added a comment. In D62761#1525917 , @NoQ wrote: > Remove "-" from program point dumps because it resembles a removal marker in > diffs. Could you add an image? I have not seen any problematic stuff, just that. CHANGES SINCE LAST ACTION

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 202514. NoQ added a comment. Remove "-" from program point dumps because it resembles a removal marker in diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files:

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ added a comment. I'll add some tests as soon as i'm sure tests for this thing actually work (by landing D62638 ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a comment. NoQ added a