This revision was automatically updated to reflect the committed changes.
Closed by commit rL366873: [clangd] Implement prepareRename
(authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hokein updated this revision to Diff 211302.
hokein marked 4 inline comments as done.
hokein added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63126/new/
https://reviews.llvm.org/D63126
Files:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:393
;
+ if (Params.capabilities.RenamePrepareSupport)
+Result["renameProvider"] =
hokein added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:393
;
+ if (Params.capabilities.RenamePrepareSupport)
+Result["renameProvider"] = llvm::json::Object{{"prepareProvider", true}};
sammccall wrote:
> why set
hokein updated this revision to Diff 211288.
hokein marked 6 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63126/new/
https://reviews.llvm.org/D63126
Files:
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:393
;
+ if (Params.capabilities.RenamePrepareSupport)
+Result["renameProvider"] = llvm::json::Object{{"prepareProvider", true}};
why set this only if the
hokein updated this revision to Diff 211080.
hokein added a comment.
Update the patch, and add tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63126/new/
https://reviews.llvm.org/D63126
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
"prepareRename" request is added in LSP v3.12.0.
No test yet, but want some early feedback.
Unfortunately, due to the
