[PATCH] D63663: [clang-doc] Add html links to references

This revision was automatically updated to reflect the committed changes. Closed by commit rL365937: [clang-doc] Add html links to references (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209534. DiegoAstiazaran edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63663/new/ https://reviews.llvm.org/D63663 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209096. DiegoAstiazaran added a comment. In tag nodes with children that are not inline, two text nodes that are adjacent won't have a new line between them. Tag nodes are still rendered in their own line. A B C D is now

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:110-113 +Inherits from +F +, +G This text should be rendered inline Comment at:

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209053. DiegoAstiazaran added a comment. Use relative paths for references/links within files. Don't fill namespaces of parentInfo in serialization and path is only generated when the parent is the global namespace. Add new fields (Path in Reference

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added a comment. I've also just noticed that the YAML generator is missing from this -- could you add the `Path` fields to hat output as well? Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:213 + llvm::SmallString<128> Path = Type.Path; +

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:567 + ParentI->Namespace = llvm::SmallVector( + Enum.Namespace.begin() + 1, Enum.Namespace.end()); + ParentI->Path = getInfoOutputFile(OutDirectory,

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 208789. DiegoAstiazaran marked 5 inline comments as done. DiegoAstiazaran added a comment. The info path generated in serialization was the composite of the out directory and the parent namespaces. Now it's only the parent namespaces; the out

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:206 + llvm::SmallString<128> Path = Type.Path; + ::llvm::sys::path::append(Path, Type.Name + ".html"); + return genLink(Type.Name, Path); You shouldn't need the

[PATCH] D63663: [clang-doc] Add html links to references

jakehehrlich added a comment. The code looks good to me. I'll let Julie give the final architectural approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63663/new/ https://reviews.llvm.org/D63663 ___ cfe-commits mailing list

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 208463. DiegoAstiazaran added a comment. Rebase after D52847 was pushed. Path added to parent Info in serialization, this is required after D63911 was pushed. CHANGES SINCE LAST

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 207611. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a parent revision: D63857: [clang-doc] Add a structured HTML generator. DiegoAstiazaran added a comment. The links are now generated using the nodes structure

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:145-146 void ProtectedMethod(); -};)raw", 3, /*Public=*/false, Infos); +};)raw", + 3, /*Public=*/false, Infos); juliehockett

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 206561. DiegoAstiazaran marked 10 inline comments as done. DiegoAstiazaran retitled this revision from "[clang-doc] Add html links to the parents of a RecordInfo" to "[clang-doc] Add html links to references". DiegoAstiazaran edited the summary of