[PATCH] D63936: [ARM] Minor fixes in command line option parsing

labrinea added a comment. @simon_tatham, thanks for clarifying. I think my change is doing the right thing then: favors the `-mfpu` option over the default CPU features. I will split the patch as @ostannard suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63936: [ARM] Minor fixes in command line option parsing

simon_tatham added a comment. I can't shed as much light as you might hope, I'm afraid, but in D62998 my intention was not to make `-mcpu=anything` win over `-mfpu=anything`. It was to make an //explicit// request to enable a feature win over an //implicit//

[PATCH] D63936: [ARM] Minor fixes in command line option parsing

labrinea added a comment. In D63936#1563872 , @ostannard wrote: > > The second change this patch makes > > Could this be spilt into two patches? Looking at D62998 more carefully I realized that we deliberately favor

[PATCH] D63936: [ARM] Minor fixes in command line option parsing

SjoerdMeijer added a comment. I will let Oliver finish the review (I am off for a few days), just some drive-by comments. Comment at: llvm/lib/Support/ARMTargetParser.cpp:412 - if (Extensions & AEK_CRC) -Features.push_back("+crc"); - else -

[PATCH] D63936: [ARM] Minor fixes in command line option parsing

ostannard added a comment. > The second change this patch makes Could this be spilt into two patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63936/new/ https://reviews.llvm.org/D63936 ___

[PATCH] D63936: [ARM] Minor fixes in command line option parsing

labrinea created this revision. labrinea added reviewers: simon_tatham, SjoerdMeijer, ostannard. Herald added subscribers: dmgreen, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. When processing the command line options `march`, `mcpu` and `mfpu`, we store the