[PATCH] D64062: Remove __VERSION__

rnk added a comment. In D64062#1584219 , @saugustine wrote: > This revision breaks python 2.7.16 builds, which are still supported by > upstream python for a few more months. I'm preparing a revert. > > The file is getcompiler.c: I just want to point

[PATCH] D64062: Remove __VERSION__

saugustine added a comment. From the failure mode I was seeing, any value at all for __VERSION__ will be fine, as long as it is a valid preprocessor string. It would also solve this particular problem to not define __GNUC__, but I as that would create other, more severe, problems, as long as

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru reopened this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. @rnk looks like it is too risky to remove it. What about changing it from #define __VERSION__ "4.2.1 Compatible Clang 7.0.1 (tags/RELEASE_701/final)" to #define

[PATCH] D64062: Remove __VERSION__

saugustine added a comment. The revert is at https://reviews.llvm.org/D64687, which I will commit shortly if there are no objections. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062

[PATCH] D64062: Remove __VERSION__

saugustine added a comment. This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert. The file is getcompiler.c: /* Return the compiler identification, if possible. */ #include "Python.h" #ifndef COMPILER #ifdef

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru added a comment. Thanks @rnk :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64062: Remove __VERSION__

This revision was automatically updated to reflect the committed changes. Closed by commit rL365962: Remove __VERSION__ (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64062: Remove __VERSION__

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, minor changes Comment at: docs/ReleaseNotes.rst:82 +Removed Compiler Options + I guess move the bullet to the generic "list of

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru added a comment. @rnk Should be good this time :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org