[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#3130696 , @whisperity wrote: > In D64454#3124312 , @aaron.ballman > wrote: > >> Yeah, I was worried this would get out of sycn and it really did not take >> long for that

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

whisperity added a comment. In D64454#3124423 , @carlosgalvezp wrote: > I was a bit confused as well about the ClangSA support in clang-tidy. What's > the current status? Is clang-tidy running *all* checks from StaticAnalyzer? If your package is built

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

carlosgalvezp added a comment. I was a bit confused as well about the ClangSA support in clang-tidy. What's the current status? Is clang-tidy running *all* checks from StaticAnalyzer? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#3122281 , @steakhal wrote: > It seems like the list got pretty outdated by the time. > Do you think we should really refer to the clang-analyzer checks in this > list? What about simply referring to the clangsa

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

steakhal added subscribers: njames93, whisperity, steakhal. steakhal added a comment. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov. Herald added a project: clang-tools-extra. It seems like the list got pretty outdated by the time. Do you think we should really refer to the

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

sylvestre.ledru added a comment. Is this failure expected? https://bugs.llvm.org/show_bug.cgi?id=44370 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 ___ cfe-commits mailing

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL367694: [clang-tidy] Adding static analyzer check to list of clang-tidy checks (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 212889. Nathan-Huckleberry added a comment. - Support python2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. This seems reasonable to me except for the fact that the script doesn't run when I try it locally. c:\llvm\tools\clang\tools\extra\docs\clang-tidy\checks>python gen-static-analyzer-docs.py Traceback (most recent call last): File

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 211987. Nathan-Huckleberry added a comment. - Order swap and elif Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. When I run the script locally, I still get issues with `subprocess.run()`. c:\llvm\tools\clang\tools\extra\docs\clang-tidy\checks>python gen-static-analyzer-docs.py Traceback (most recent call last): File "gen-static-analyzer-docs.py", line 148, in

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 211967. Nathan-Huckleberry added a comment. - Add in-tree as possible default location Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py:113 + file_path_help = ("Path to Checkers.td, defaults to ../../../../clang/include/clang/StaticAnalyzer/Checkers/") + parse.add_argument("file", type=str,

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 211958. Nathan-Huckleberry added a comment. - Make filepath optionally user specified Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#1601439 , @nickdesaulniers wrote: > In D64454#1600922 , @aaron.ballman > wrote: > > > I use svn in-tree, so I tried it out and it does not seem to work for me. > > > >

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

nickdesaulniers added a comment. In D64454#1600922 , @aaron.ballman wrote: > I use svn in-tree, so I tried it out and it does not seem to work for me. > > c:\llvm\tools\clang\tools\extra\docs\clang-tidy\checks>python > gen-static-analyzer-docs.py >

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#1598043 , @Nathan-Huckleberry wrote: > In D64454#1587102 , @aaron.ballman > wrote: > > > I think this looks reasonable to me, though I am still not certain if the > >

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. In D64454#1587102 , @aaron.ballman wrote: > I think this looks reasonable to me, though I am still not certain if the > relative path in the python script will work with both the svn in-tree > directory layout as

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Szelethus added a comment. In D64454#1587102 , @aaron.ballman wrote: > I think this looks reasonable to me, though I am still not certain if the > relative path in the python script will work with both the svn in-tree > directory layout as well as the

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. I think this looks reasonable to me, though I am still not certain if the relative path in the python script will work with both the svn in-tree directory layout as well as the git monorepo layout (which I'm far less familiar with). Repository: rG LLVM Github

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Szelethus added a comment. I don't see obvious red flags strictly regarding the analyzer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 ___ cfe-commits

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 209634. Nathan-Huckleberry added a comment. - Forgot to fix list.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 209632. Nathan-Huckleberry added a comment. - Added script for generation of docs based off Checkers.td - Updated to match newly standardized anchor urls - Add auto redirect and remove alpha checkers Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry updated this revision to Diff 209532. Nathan-Huckleberry added a comment. - Add auto redirect and remove alpha checkers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py:67 + with open(os.path.join(__location__, checker["FullPackageName"]+".rst"),"w") as f: +f.write(".. title:: clang-tidy - %s\n" %

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py:2-3 +""" +Generates documentation based off the available static analyzers checks +References Checkers.td to determine what checks exist +"""

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. In D64454#1579481 , @Eugene.Zelenko wrote: > In D64454#1579466 , > @Nathan-Huckleberry wrote: > > > Docs exist for these checks on the analyzer side, they're just all on the >

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Eugene.Zelenko added a comment. In D64454#1579466 , @Nathan-Huckleberry wrote: > Docs exist for these checks on the analyzer side, they're just all on the > same page and hyperlinking to them individually is difficult because the > links have a

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. In D64454#1579365 , @lebedev.ri wrote: > In D64454#1579336 , @Eugene.Zelenko > wrote: > > > May be script should generate documentation during build, so files .rst > > files

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

lebedev.ri added a comment. In D64454#1579336 , @Eugene.Zelenko wrote: > May be script should generate documentation during build, so files .rst files > are not needed? I'd personally weakly advise against that, to be honest; that would not be

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Eugene.Zelenko added a comment. May be script should generate documentation during build, so files .rst files are not needed? Please also insert empty line between header (===) and text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry marked an inline comment as done. Nathan-Huckleberry added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/clang-analyzer-apiModeling.StdCLibraryFunctions.rst:7 +The clang-analyzer-apiModeling.StdCLibraryFunctions check is an alias,

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#1578704 , @Szelethus wrote: > Just thinking aloud! > > We were tinkering with the idea of a checker creator script similar to what > clang-tidy has, that could help on this potentially. > > Is generating the rst

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. In D64454#1578352 , @aaron.ballman wrote: > I'm worried that this will continue to drift out of sync with the static > analyzer checks unless we find some way to automate it. I wonder if we could > write a script to

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Szelethus added a comment. Just thinking aloud! We were tinkering with the idea of a checker creator script similar to what clang-tidy has, that could help on this potentially. Is generating the rst code with Tblgen a feasable approach? At first glance, it sounds like a nightmare to

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

NoQ added a comment. In D64454#1578352 , @aaron.ballman wrote: > I'm worried that this will continue to drift out of sync with the static > analyzer checks unless we find some way to automate it. I wonder if we could > write a script to generate these

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added reviewers: NoQ, Szelethus. aaron.ballman added a subscriber: NoQ. aaron.ballman added a comment. I'm worried that this will continue to drift out of sync with the static analyzer checks unless we find some way to automate it. I wonder if we could write a script to generate

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/clang-analyzer-apiModeling.StdCLibraryFunctions.rst:4 +clang-analyzer-apiModeling.StdCLibraryFunctions

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. The contents of each check page are identical other than the check name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: clang. Since clang-tidy supports use of the static analyzer there should be documentation of how to invoke the static