[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 216805. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Addressed more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 216669. SureYeaah marked 33 inline comments as done. SureYeaah added a comment. Herald added a subscriber: mgrang. Addressed Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

sammccall added a comment. Main themes are: - there are a few places we can reduce scope for the first patch: e.g. template support - internally, it'd be clearer to pass data around in structs and avoid complex classes unless the abstraction is important - high-level documentation would aid in

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:68 + bool hasOnlyRootStmtChildren(); + // We only support extraction of RootStmts. A RootStmt as a statement that is + // fully selected including all of it's children.

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215615. SureYeaah added a comment. Fixed semicolon bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215574. SureYeaah added a comment. Fixed bug in getLocType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215131. SureYeaah added a comment. Better Naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215098. SureYeaah added a comment. Removed debug info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215089. SureYeaah added a comment. Removed unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215077. SureYeaah marked 11 inline comments as done. SureYeaah added a comment. Refactored design and added unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:211 + // Note that DRELocType is never OUTSIDECONTEXT. + if (DeclLocType + 1 != DRELocType) +return; SureYeaah wrote: > sammccall wrote: > > this line

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah marked 2 inline comments as done. SureYeaah added a comment. In D65526#1612117 , @sammccall wrote: > I guess you're looking for design review at this point. > > But the most important part of that is the documentation of the high-level >

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

sammccall added a comment. I guess you're looking for design review at this point. But the most important part of that is the documentation of the high-level structure, which is entirely missing. I can't really infer it from the code because most of the design is (presumably) not implemented

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah created this revision. SureYeaah added reviewers: kadircet, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. - Prototype version; Only looking for a high level review. - Only works for extraction from