This revision was automatically updated to reflect the committed changes.
Closed by commit rL369098: [ASTImporter] Import ctor initializers after setting
flags. (authored by balazske, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
balazske added a comment.
LLDB probably does the import in other way. CTU test fails without the fix:
FAIL: Clang :: Analysis/ctu-main.cpp (540 of 15341)
TEST 'Clang :: Analysis/ctu-main.cpp' FAILED
Script:
--
: 'RUN: at line 1'; rm -rf
buil
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
I was hoping to be able reproduce this in LLDB via an expression like this:
expr testImportOfDelegateConstructor(10) == 10
but it does not. I am assuming the test ctu test case invokes the i
balazske updated this revision to Diff 215056.
balazske added a comment.
- Moved 'ctor initializer' import before import of body.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65935/new/
https://reviews.llvm.org/D65935
Files:
clang/lib/AST/ASTIm
a_sidorin added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:3293
+ // Import Ctor initializers.
+ if (auto *FromConstructor = dyn_cast(D)) {
I suggest to move it closer to the function body import because import of ctor
initializers is a part
balazske added a comment.
In this case the problem was that some of the flags of the already created and
inserted `ToFunction` are not initialized. During the import of some "ctor
initializers" this non-complete ToFunction may be accessed somehow (by
structural equivalence or other code) and an
a_sidorin added a comment.
Hello Balazs,
Do I understand correctly that it was unset
`ToFunction->setLexicalDeclContext(LexicalDC);` that caused lookup problems?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65935/new/
https://reviews.llvm.org/D65
balazske created this revision.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: martong.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
Code to import "ctor initializers" at import of functions
is mo
