[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

2019-08-29 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 217785. jvikstrom marked an inline comment as done. jvikstrom added a comment. Use `conf.affectsConfiguration('workbench.colorTheme')` instead of keeping track of the old color theme manually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

2019-08-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. please update the description of the patch. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:104 +vscode.workspace.onDidChangeConfiguration((conf) => { + if

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

2019-08-28 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 217638. jvikstrom added a comment. Updated to new master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66406/new/ https://reviews.llvm.org/D66406 Files:

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

2019-08-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. the change looks good, but I'd wait until D66219 is finished. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66406/new/ https://reviews.llvm.org/D66406

[PATCH] D66406: [clangd] Update themeRuleMatcher when color theme changes in vscode extension.

2019-08-19 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Add event listener that listens to configuration changes and reloads the ThemeRuleMatcher when the theme