[PATCH] D68155: [clang][NFC] Make various uses of Regex const

2019-11-19 Thread Nicolas Guillemot via Phabricator via cfe-commits
nlguillemot added a comment. In D68155#1751826 , @thopre wrote: > My sincere apologies, I forgot to change the author in the commit. I don't > often commit on behalf of others so didn't think enough. No worries. Thanks again for helping with the

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

2019-11-19 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre added a comment. My sincere apologies, I forgot to change the author in the commit. I don't often commit on behalf of others so didn't think enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

2019-11-19 Thread Thomas Preud'homme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb81cc6032902: [clang][NFC] Make various uses of Regex const (authored by thopre). Changed prior to commit: https://reviews.llvm.org/D68155?vs=26=230079#toc Repository: rG LLVM Github Monorepo

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

2019-11-18 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155 ___ cfe-commits

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

2019-09-27 Thread Nicolas Guillemot via Phabricator via cfe-commits
nlguillemot created this revision. nlguillemot added a reviewer: thopre. Herald added a project: clang. Herald added a subscriber: cfe-commits. The const-correctness of match() was fixed in rL372764 , which allows uses of Regex objects to be const in cases they