jdoerfert added a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70245/new/
https://reviews.llvm.org/D70245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4e8231b5cf0f: [OPENMP50]Add device/kind context selector
support. (authored by ABataev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70245/new/
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70245/new/
https://reviews.llvm.org/D70245
ABataev added a comment.
More comments?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70245/new/
https://reviews.llvm.org/D70245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev updated this revision to Diff 229843.
ABataev added a comment.
Address comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70245/new/
https://reviews.llvm.org/D70245
Files:
clang/include/clang/Basic/Attr.td
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: clang/test/OpenMP/declare_variant_device_kind_codegen.cpp:81
+#define SUBSET host, cpu
+#define WRONG cpu, gpu
+#endif // CPU
jdoerfert wrote:
> What is wrong about cpu, gpu
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11247
+RHSIsSubsetOfLHS = true;
+ } else {
+for (const OMPContextSelectorData : LHS) {
Nit: `bool RHSIsSubsetOfLHS = isStrictSubset(RHS, LHS)`
saves you a line later.
ABataev created this revision.
ABataev added a reviewer: jdoerfert.
Herald added subscribers: s.egerton, guansong, simoncook, fedor.sergeev,
aheejin, rampitec.
Herald added a project: clang.
Added basic parsing/sema support for device/kind context selector.
Repository:
rG LLVM Github
