[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

sammccall added a comment. Sorry about the bad rebase, I landed the right version i think :-) In D70325#1750496 , @sammccall wrote: > In D70325#1749432 , @kadircet wrote: > > > LGTM, with a question. What about

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

This revision was automatically updated to reflect the committed changes. Closed by commit rGe51484abd402: [clangd] Fix hover local scope to include class template params (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D70325?vs=229910=230004#toc Repository: rG

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! but again it looks as if rebasing went wrong :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70325/new/

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

sammccall added a comment. In D70325#1749432 , @kadircet wrote: > LGTM, with a question. What about default template params? I believe we would > also like to print them, could you add a test case for that? They're not printed, as the type is "as

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

sammccall updated this revision to Diff 229910. sammccall added a comment. add fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70325/new/ https://reviews.llvm.org/D70325 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

kadircet added a comment. LGTM, with a question. What about default template params? I believe we would also like to print them, could you add a test case for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70325/new/

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

merge_guards_bot added a comment. Build result: fail - 60138 tests passed, 2 failed and 729 were skipped. failed: LLVM.CodeGen/NVPTX/vectorize-misaligned.ll failed: LLVM.Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll Log files: console-log.txt

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes the last part of https://github.com/clangd/clangd/issues/76 Repository: rG LLVM Github