[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-19 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b5f6c16476c: [clang-format] [NFC] add recent changes to release notes (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-18 Thread Mitchell via Phabricator via cfe-commits
mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/ https://reviews.llvm.org/D70355 ___ cfe-commits

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, sylvestre.ledru, sammccall. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added a comment. @Eugene.Zelenko I've noticed you are

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. General comments: - Isn't //Option(s) ... was/were added// or //Option(s) ... had been added// are more correct from from point of view of English grammar? Same for older entries. - It'll be great to nag developers to expand Release Notes when relevant code

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added a comment. @Eugene.Zelenko I've noticed you are always giving excellent review feedback in clang-tidy especially around the documentation, I'd appreciate your eyes on finding the right level of documentation here.

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 60143 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

2019-11-16 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 229690. MyDeveloperDay added a comment. Address review comments Remove excessive newlines Remove trailing whitespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70355/new/ https://reviews.llvm.org/D70355 Files: