This revision was automatically updated to reflect the committed changes.
Closed by commit rG01d8e09fdba0: [clang][CodeGen] Fix wrong memcpy size of
no_unique_address in FieldMemcpyizer (authored by zsrkmyn, committed by
MaskRay).
Changed prior to commit:
zsrkmyn updated this revision to Diff 230991.
zsrkmyn added a comment.
Thanks for reviewing! Would you mind helping me commit this patch? Thanks :-D
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70671/new/
https://reviews.llvm.org/D70671
Files:
clang/lib/CodeGen/CGClass.cpp
MaskRay accepted this revision.
MaskRay added inline comments.
Comment at: clang/test/CodeGenCXX/no-unique-address-2.cpp:17
+
+void call()
+{
`{` on the same line of `call()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70671/new/
https://reviews.llvm.org/D70671
zsrkmyn created this revision.
zsrkmyn added reviewers: erichkeane, aaron.ballman, MaskRay, rjmccall.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When generating ctor, FieldMemcpyizer wrongly treated zero-sized class members
as what should be copied, and generated wrong
