[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-28 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D72527#1845009 , @Eugene.Zelenko wrote: > Rebase from master. Committed, I still not 100% sure on landing on behalf of someone else so I think it hasn't credited you unfortunately, arc should have better docs...

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-28 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG66e47a57205b: [clang-tidy] adjust scripts to subsubsections in Release Notes (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-28 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko updated this revision to Diff 240922. Eugene.Zelenko added a comment. Rebase from master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 Files:

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-28 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In D72527#1843475 , @Eugene.Zelenko wrote: > As I wrote, I don't have GitHub commit access, so I need help with commit. Sorry, missed that part of the patch description. As per Nathan's comment, please rebase the patch.

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-28 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D72527#1843475 , @Eugene.Zelenko wrote: > As I wrote, I don't have GitHub commit access, so I need help with commit. Needs rebasing on trunk, ReleaseNotes.rst is causing conflicts Repository: rG LLVM Github Monorepo

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-27 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. As I wrote, I don't have GitHub commit access, so I need help with commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 ___

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-27 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In D72527#1843427 , @Eugene.Zelenko wrote: > Just ping. Are you waiting for other reviewers or for me to "Accept Revision"? If the latter,

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-27 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Just ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In D72527#1817518 , @Eugene.Zelenko wrote: > Both scripts works fine. However rename script should also sort entries > alphabetically, but probably this should be separate patch. Yep, sorting of the list on rename is a separate

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko marked an inline comment as done. Eugene.Zelenko added a comment. Both scripts works fine. However rename script should also sort entries alphabetically, but probably this should be separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko updated this revision to Diff 237720. Eugene.Zelenko added a comment. Renamed "New aliases" to "New check aliases". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 Files:

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. LG with a nit, if this works. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:223 + lineMatcher = re.compile('New checks') + nextSectionMatcher = re.compile('New aliases') checkerMatcher = re.compile('- New :doc:`(.*)')

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-10 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: aaron.ballman, alexfh, hokein. Eugene.Zelenko added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. I added subsubsections for typical Clang-tidy entries in Release Notes, so