[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Nathan James via Phabricator via cfe-commits]

njames93 added a comment.

In D72527#1845009 , @Eugene.Zelenko 
wrote:

> Rebase from master.


Committed, I still not 100% sure on landing on behalf of someone else so I 
think it hasn't credited you unfortunately, arc should have better docs...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Nathan James via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG66e47a57205b: [clang-tidy] adjust scripts to subsubsections 
in Release Notes (authored by njames93).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527

Files:
  clang-tools-extra/clang-tidy/add_new_check.py
  clang-tools-extra/clang-tidy/rename_check.py
  clang-tools-extra/docs/ReleaseNotes.rst


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -88,8 +88,8 @@
   Flags use of the `C` standard library functions ``memset``, ``memcpy`` and
   ``memcmp`` and similar derivatives on non-trivial types.
 
-New aliases
-^^^
+New check aliases
+^
 
 - New alias :doc:`cert-dcl37-c
   ` to
Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New check aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -88,8 +88,8 @@
   Flags use of the `C` standard library functions ``memset``, ``memcpy`` and
   ``memcmp`` and similar derivatives on non-trivial types.
 
-New aliases
-^^^
+New check aliases
+^
 
 - New alias :doc:`cert-dcl37-c
   ` to
Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New check aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko updated this revision to Diff 240922.
Eugene.Zelenko added a comment.

Rebase from master.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527

Files:
  clang-tools-extra/clang-tidy/add_new_check.py
  clang-tools-extra/clang-tidy/rename_check.py
  clang-tools-extra/docs/ReleaseNotes.rst


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -88,8 +88,8 @@
   Flags use of the `C` standard library functions ``memset``, ``memcpy`` and
   ``memcmp`` and similar derivatives on non-trivial types.
 
-New aliases
-^^^
+New check aliases
+^
 
 - New alias :doc:`cert-dcl37-c
   ` to
Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New check aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -88,8 +88,8 @@
   Flags use of the `C` standard library functions ``memset``, ``memcpy`` and
   ``memcmp`` and similar derivatives on non-trivial types.
 
-New aliases
-^^^
+New check aliases
+^
 
 - New alias :doc:`cert-dcl37-c
   ` to
Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New check aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D72527#1843475 , @Eugene.Zelenko 
wrote:

> As I wrote, I don't have GitHub commit access, so I need help with commit.


Sorry, missed that part of the patch description. As per Nathan's comment, 
please rebase the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Nathan James via Phabricator via cfe-commits]

njames93 added a comment.

In D72527#1843475 , @Eugene.Zelenko 
wrote:

> As I wrote, I don't have GitHub commit access, so I need help with commit.


Needs rebasing on trunk, ReleaseNotes.rst is causing conflicts


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

As I wrote, I don't have GitHub commit access, so I need help with commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

In D72527#1843427 , @Eugene.Zelenko 
wrote:

> Just ping.


Are you waiting for other reviewers or for me to "Accept Revision"? If the 
latter, "stamped", but I've already said that the patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Just ping.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D72527#1817518 , @Eugene.Zelenko 
wrote:

> Both scripts works fine. However rename script should also sort entries 
> alphabetically, but probably this should be separate patch.


Yep, sorting of the list on rename is a separate issue.
The patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko marked an inline comment as done.
Eugene.Zelenko added a comment.

Both scripts works fine. However rename script should also sort entries 
alphabetically, but probably this should be separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko updated this revision to Diff 237720.
Eugene.Zelenko added a comment.

Renamed "New aliases" to "New check aliases".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527

Files:
  clang-tools-extra/clang-tidy/add_new_check.py
  clang-tools-extra/clang-tidy/rename_check.py
  clang-tools-extra/docs/ReleaseNotes.rst


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -171,8 +171,8 @@
   Finds classes, structs, and unions that contain redundant member
   access specifiers.
 
-New aliases
-^^^
+New check aliases
+^
 
 - New alias :doc:`cert-pos44-c
   ` to
Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New check aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 


Index: clang-tools-extra/docs/ReleaseNotes.rst
===
--- clang-tools-extra/docs/ReleaseNotes.rst
+++ clang-tools-extra/docs/ReleaseNotes.rst
@@ -171,8 +171,8 @@
   Finds classes, structs, and unions that contain redundant member
   access specifiers.
 
-New aliases
-^^^
+New check aliases
+^
 
 - New alias :doc:`cert-pos44-c
   ` to
Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New check aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

LG with a nit, if this works.




Comment at: clang-tools-extra/clang-tidy/add_new_check.py:223
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')

"New check aliases" would be less ambiguous.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72527/new/

https://reviews.llvm.org/D72527



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: aaron.ballman, alexfh, hokein.
Eugene.Zelenko added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Herald added a project: clang.

I added subsubsections for typical Clang-tidy entries in Release Notes, so now 
scripts are aware of this changes.

I don't have GitHub commit access, so please commit changes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72527

Files:
  clang-tools-extra/clang-tidy/add_new_check.py
  clang-tools-extra/clang-tidy/rename_check.py


Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 


Index: clang-tools-extra/clang-tidy/rename_check.py
===
--- clang-tools-extra/clang-tidy/rename_check.py
+++ clang-tools-extra/clang-tidy/rename_check.py
@@ -176,11 +176,11 @@
 
 for line in lines:
   if not note_added:
-match = re.search('Improvements to clang-tidy', line)
+match = re.search('Renamed checks', line)
 if match:
   header_found = True
 elif header_found:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""
 - The '%s' check was renamed to :doc:`%s
   `
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_check.py
+++ clang-tools-extra/clang-tidy/add_new_check.py
@@ -219,8 +219,8 @@
   with open(filename, 'r') as f:
 lines = f.readlines()
 
-  lineMatcher = re.compile('Improvements to clang-tidy')
-  nextSectionMatcher = re.compile('Improvements to clang-include-fixer')
+  lineMatcher = re.compile('New checks')
+  nextSectionMatcher = re.compile('New aliases')
   checkerMatcher = re.compile('- New :doc:`(.*)')
 
   print('Updating %s...' % filename)
@@ -249,12 +249,12 @@
   f.write(line)
   continue
 
-if line.startswith(''):
+if line.startswith(''):
   f.write(line)
   continue
 
 if header_found and add_note_here:
-  if not line.startswith(''):
+  if not line.startswith(''):
 f.write("""- New :doc:`%s
   ` check.
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits